refactor(smudge): Replace custom doubly linked list with std::deque in W3DSmudge - #3021
Open
stephanmeesters wants to merge 3 commits into
Open
refactor(smudge): Replace custom doubly linked list with std::deque in W3DSmudge#3021stephanmeesters wants to merge 3 commits into
stephanmeesters wants to merge 3 commits into
Conversation
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Include/GameClient/Smudge.h | Replaces intrusive-list types and node inheritance with deque aliases while preserving the public smudge-management contract used by current callers. |
| Core/GameEngine/Source/GameClient/System/Smudge.cpp | Converts pool ownership and traversal to explicit deque operations, removes unused APIs, and fixes free-smudge cleanup to pop from the correct queue. |
| Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp | Converts both render passes and cross-batch resume state to deque iterators while preserving progress across hidden smudges, empty sets, and batch boundaries. |
Reviews (1): Last reviewed commit: "Refactor smudge count to use current que..." | Re-trigger Greptile
stephanmeesters
added
the
Refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DLListClassusages inW3DSmudgewithstd::deque.std::dequewas chosen instead ofstd::listbecause we only needed removals/insertions at the front/back (no splicing).m_usedSmudgeCountwith the queue's size